From c9c04ebdeab4704f7f5ca405ba1b2d61fbc0f932 Mon Sep 17 00:00:00 2001 From: Joel Sherrill Date: Fri, 10 Oct 2025 13:04:10 -0500 Subject: [PATCH] arm/smdk2410: Address unused parameter warnings Add "(void) param;" annotation to address unused parameter warnings. Found with GCC's warning -Wunused-parameter. --- bsps/arm/smdk2410/clock/clockdrv.c | 5 ++++- bsps/arm/smdk2410/console/uart.c | 13 +++++++++++++ bsps/arm/smdk2410/irq/irq.c | 21 +++++++++++++++++++++ bsps/arm/smdk2410/smc/smc.c | 6 ++++++ bsps/arm/smdk2410/start/bspidle.c | 2 ++ 5 files changed, 46 insertions(+), 1 deletion(-) diff --git a/bsps/arm/smdk2410/clock/clockdrv.c b/bsps/arm/smdk2410/clock/clockdrv.c index c2b96c978f..be890078c1 100644 --- a/bsps/arm/smdk2410/clock/clockdrv.c +++ b/bsps/arm/smdk2410/clock/clockdrv.c @@ -108,6 +108,7 @@ rtems_irq_connect_data clock_isr_data = { */ static void clock_isr_on(const rtems_irq_connect_data *unused) { + (void) unused; } /** @@ -117,7 +118,7 @@ static void clock_isr_on(const rtems_irq_connect_data *unused) */ static void clock_isr_off(const rtems_irq_connect_data *unused) { - return; + (void) unused; } /** @@ -128,6 +129,8 @@ static void clock_isr_off(const rtems_irq_connect_data *unused) */ static int clock_isr_is_on(const rtems_irq_connect_data *irq) { + (void) irq; + return 1; } diff --git a/bsps/arm/smdk2410/console/uart.c b/bsps/arm/smdk2410/console/uart.c index e7a337cc3c..16c23e2c5b 100644 --- a/bsps/arm/smdk2410/console/uart.c +++ b/bsps/arm/smdk2410/console/uart.c @@ -124,6 +124,10 @@ console_tbl Console_Configuration_Ports[] = { */ static int uart_first_open(int major, int minor, void *arg) { + (void) major; + (void) minor; + (void) arg; + return 0; } @@ -135,6 +139,10 @@ static int uart_first_open(int major, int minor, void *arg) */ static int uart_last_close(int major, int minor, void *arg) { + (void) major; + (void) minor; + (void) arg; + return 0; } @@ -194,6 +202,8 @@ static ssize_t uart_write(int minor, const char *buf, size_t len) /* Set up the UART. */ static void uart_init(int minor) { + (void) minor; + int i; unsigned int reg = 0; @@ -228,6 +238,9 @@ static void uart_write_polled(int minor, char c) /* This is for setting baud rate, bits, etc. */ static int uart_set_attributes(int minor, const struct termios *t) { + (void) minor; + (void) t; + return 0; } diff --git a/bsps/arm/smdk2410/irq/irq.c b/bsps/arm/smdk2410/irq/irq.c index ec350c1d57..ac496b5af3 100644 --- a/bsps/arm/smdk2410/irq/irq.c +++ b/bsps/arm/smdk2410/irq/irq.c @@ -34,6 +34,9 @@ rtems_status_code bsp_interrupt_get_attributes( rtems_interrupt_attributes *attributes ) { + (void) vector; + (void) attributes; + return RTEMS_SUCCESSFUL; } @@ -42,6 +45,8 @@ rtems_status_code bsp_interrupt_is_pending( bool *pending ) { + (void) vector; + bsp_interrupt_assert(bsp_interrupt_is_valid_vector(vector)); bsp_interrupt_assert(pending != NULL); *pending = false; @@ -50,12 +55,16 @@ rtems_status_code bsp_interrupt_is_pending( rtems_status_code bsp_interrupt_raise(rtems_vector_number vector) { + (void) vector; + bsp_interrupt_assert(bsp_interrupt_is_valid_vector(vector)); return RTEMS_UNSATISFIED; } rtems_status_code bsp_interrupt_clear(rtems_vector_number vector) { + (void) vector; + bsp_interrupt_assert(bsp_interrupt_is_valid_vector(vector)); return RTEMS_UNSATISFIED; } @@ -65,6 +74,8 @@ rtems_status_code bsp_interrupt_vector_is_enabled( bool *enabled ) { + (void) vector; + bsp_interrupt_assert(bsp_interrupt_is_valid_vector(vector)); bsp_interrupt_assert(enabled != NULL); *enabled = false; @@ -73,12 +84,16 @@ rtems_status_code bsp_interrupt_vector_is_enabled( rtems_status_code bsp_interrupt_vector_enable(rtems_vector_number vector) { + (void) vector; + bsp_interrupt_assert(bsp_interrupt_is_valid_vector(vector)); return RTEMS_SUCCESSFUL; } rtems_status_code bsp_interrupt_vector_disable(rtems_vector_number vector) { + (void) vector; + bsp_interrupt_assert(bsp_interrupt_is_valid_vector(vector)); return RTEMS_SUCCESSFUL; } @@ -88,6 +103,9 @@ rtems_status_code bsp_interrupt_set_priority( uint32_t priority ) { + (void) vector; + (void) priority; + bsp_interrupt_assert(bsp_interrupt_is_valid_vector(vector)); return RTEMS_UNSATISFIED; } @@ -97,6 +115,9 @@ rtems_status_code bsp_interrupt_get_priority( uint32_t *priority ) { + (void) vector; + (void) priority; + bsp_interrupt_assert(bsp_interrupt_is_valid_vector(vector)); bsp_interrupt_assert(priority != NULL); return RTEMS_UNSATISFIED; diff --git a/bsps/arm/smdk2410/smc/smc.c b/bsps/arm/smdk2410/smc/smc.c index 944b9315fb..8124cfb1dd 100644 --- a/bsps/arm/smdk2410/smc/smc.c +++ b/bsps/arm/smdk2410/smc/smc.c @@ -360,6 +360,8 @@ smc_read(rtems_blkdev_request *req) static int smc_ioctl(rtems_disk_device *dd, uint32_t req, void *argp) { + (void) dd; + switch (req) { case RTEMS_BLKIO_REQUEST: @@ -402,6 +404,10 @@ smc_initialize( rtems_device_minor_number minor, void *arg) { + (void) major; + (void) minor; + (void) arg; + rtems_status_code rc; uint32_t block_num; diff --git a/bsps/arm/smdk2410/start/bspidle.c b/bsps/arm/smdk2410/start/bspidle.c index 9f0705b4d8..51f404742f 100644 --- a/bsps/arm/smdk2410/start/bspidle.c +++ b/bsps/arm/smdk2410/start/bspidle.c @@ -17,6 +17,8 @@ void *bsp_idle_thread(uintptr_t ignored) { + (void) ignored; + while(1) { __asm__ volatile ("MCR p15,0,r0,c7,c0,4 \n"); }